fix: ensure ready-to-show event is fired #25672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
This reverts commit e5933c6.
When this chromium change landed: https://chromium-review.googlesource.com/c/chromium/src/+/2215143 event `ready-to-show` is not always emitted. This change ensures that it will be fired exactly at the same moment it was being fired before problematic chromium change landed.
4 tasks
codebytere
approved these changes
Sep 29, 2020
|
Release Notes Persisted
|
codebytere
deleted the
trop/11-x-y-bp-fix-ensure-ready-to-show-event-is-fired-1601325431974
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25632
See that PR for details.
Notes: Fix ready-to-show event not emitted on some machines.